*** amccarthy is now known as Guest8394 | 06:05 | |
*** amccarthy_ is now known as amccarthy | 06:06 | |
*** amccarthy is now known as Guest8398 | 07:27 | |
*** amccarthy_ is now known as amccarthy | 07:27 | |
dcaliste | Hello pvuorela. Thank you for your remarks last Friday on the search PRs. I didn't have time to address them before late yesterday though :/ | 08:03 |
---|---|---|
pvuorela | dcaliste: sure, np. | 08:04 |
pvuorela | dcaliste: (and hi) | 08:04 |
dcaliste | For the QML bindings, I've changed the 'pattern' property for a more neutral 'searchString'. | 08:05 |
pvuorela | yea, just noticed that. thanks. quite minor things commented the last time. didn't yet test the latest version, but i have a feeling it might nearing good enough for a basic version. | 08:07 |
pvuorela | though nemo-calendar is marked wip still. did you have some concerns still there? | 08:08 |
dcaliste | Ok, thanks. I need to retest it myself also, after various rebases due to the property name change. I'm also wondering about your remark on the displayed date time for recurring events.… | 08:08 |
dcaliste | About the WIP, no I can now remove it I think. | 08:09 |
dcaliste | So, for recurring events, I'm wondering if I could use getNextOccurrence() on recurring events to display them. | 08:10 |
pvuorela | that would be nice. then we could maybe keep the year section and it wouldn't be so strange. | 08:11 |
dcaliste | It could be a bit "heavy" though because getNextOccurrence() is done in the working thread and doing it repeatedly for every recurring events in the search result list could be hardcore… | 08:11 |
dcaliste | It would also need reordering of the identifier list in that case. Quite a lot of additional code. But I'm surely try to investigate in that direction to see if it can be done. | 08:13 |
dcaliste | Maybe as a separate PR though. | 08:13 |
pvuorela | hm, right. maybe there could be a chance to find the next occurrence for each event when doing the search, but that could need a bit separate mechanism. | 08:16 |
pvuorela | that is, on passing the results from worker to manager and to qml. | 08:17 |
pvuorela | but if we don't do that yet, thinking should we then skip the year section until that. | 08:17 |
dcaliste | Yes, I can remove the commit introducing the section and keep it in this potential second PR adding getNextOccurrence(). | 08:19 |
dcaliste | Ok, so I've removed the section from PR#45 in QML bindings and in the UI PR also. I've started a mostly empty WIP PR in the QML binding with just the section commit. | 08:26 |
pvuorela | alright, good. | 08:28 |
dcaliste | Looking at getNextOccurrence(), it is returning the next occurrence, being an exception if it happens to be the case. What if the exception does not contains the matching string (because it has been indeed modified from the parent) ? | 08:36 |
dcaliste | In the same spirit, if we use getNextOccurrence(), then, I guess we should drop the exceptions as event themselves in the esarch result list. But what if the exception is the only case where there is a matching string while the parent don't have it ? | 08:37 |
dcaliste | Are these to corner cases that we should not care about (my opinion), or should they be treated properly ? | 08:37 |
pvuorela | on initial versions could maybe just acknowledge the details with exceptions. | 08:38 |
dcaliste | At the moment, parent and exceptions are treated as single events, I mean, if parent matches is it listed at its first occurrence place, if exception matches it is listed at its right date and time. If both match, both are listed. If only one of them match, only the matching incidence is listed. | 08:40 |
dcaliste | Maybe I don't understand your reply, but the question was more about the next step, with a list driven by occurrence and not by incidence. | 08:41 |
pvuorela | i mean if there are difficulties implementing the ideal way to handle recurring events + exception + search string result only in one, i could accept some shortcomings on the early versions if those are acknowledged as something to fix eventually. | 08:45 |
dcaliste | Ok, I see. So first let's have the current PRs validated (or not) with a search result incidence oriented, without year section. In the meantime, I'll try to implement a version occurrence oriented with year section and see if it is more convenient, without too much performance penalty. | 08:48 |
pvuorela | yea. i'll test the current version and show to martin again. | 08:50 |
dcaliste | Great, thanks. | 08:53 |
piggz | attah: i made a saple porject and guide for you :) https://github.com/sailfishos-chum/qt5/wiki/Getting-Started | 12:51 |
piggz | dracks[m]: can you update your submission to chum to include a license please, see https://github.com/sailfishos-chum/main/blob/main/Maintainer.md for guidance | 13:37 |
dracks[m] | I was thinking I changed it yesterday in the source code! sorry: https://gitlab.com/dracks/quicklaunchslx/-/commit/0c08798a3c6889d5470def1e0bd38d4ebfa304b9 | 15:44 |
dracks[m] | this should fix it right? https://gitlab.com/dracks/quicklaunchslx/-/commit/5055266c128ca58cf81d8208b056ff9fde939a8b | 15:46 |
dracks[m] | I saw now the tag should be GPLv3 | 15:49 |
dracks[m] | I submit it again, hope this one is everything right! | 17:45 |
rinigus | dracks: I have accepted the app, thank you very much! you are also made a maintainer in :testing. when you see that it works in :testing, submit it to chum proper | 17:59 |
attah | piggz: Saw that! Much appreciated! | 18:42 |
piggz | attah: the demo could be better, but, its a start, and we can update it | 18:43 |
attah | But i hit one snag... the resulting package requires qt-runner and it does not appear to be provided | 18:43 |
piggz | i was lazy, installed to /opt, and used a qrc instead of installing qml files in /usr/share.. | 18:43 |
piggz | attah: at-runner is in chum | 18:43 |
attah | Busted, i guess | 18:45 |
attah | I install the installer thingy and it just disappears | 18:47 |
piggz | https://build.sailfishos.org/package/show/sailfishos:chum/qt-runner | 18:47 |
rinigus | lbt: I have some weird issue with a build just stopping: https://build.merproject.org/package/live_build_log/home:rinigus:qt515:devel:test/qtwebengine/sailfish_latest_aarch64/aarch64 | 18:47 |
rinigus | in this case, make -j1 is used as a regular seemed to crash - probably due to RAM use at OBS | 18:48 |
piggz | ^^rinigus trying to make the server fall over :D | 18:48 |
rinigus | there is also strange difference between SDK and OBS builders. With SDK mb2 build process terminates early and spits out loads of (WARNING) qmake[1146683/-142899392] Path not found for FD 3, for __fxstatat64() | 18:49 |
rinigus | that doesn't happen at OBS. | 18:49 |
piggz | rinigus: those fxstat64 happen on all sdk builds for me, failure is usually before thet | 18:50 |
attah | Could not find the Qt platform plugin "wayland" in "" | 18:51 |
attah | This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem. | 18:52 |
attah | :( | 18:52 |
rinigus | piggz: true. in my case, it fails to run PERL script in aarch64, but happily runs it with x86. on SDK. | 18:52 |
rinigus | attah: you have to install opt-qt5-qtwayland | 18:52 |
piggz | attah: not far .... as rinigu says | 18:52 |
rinigus | we will have to provide a list of nice packages | 18:52 |
piggz | will add it to the .spec | 18:52 |
attah | not found in the specific repo... i guess chum too? | 18:53 |
piggz | no, should be in the normal at515 repo | 18:54 |
rinigus | attah: no, that in this obscure OBS repo with qt515 packages | 18:54 |
attah | pkcon seems to disagree... let me whack it some | 18:54 |
rinigus | also, install opt-qt5-sfos-maliit-platforminputcontext to get SFOS keyboard working with your app | 18:54 |
piggz | https://build.merproject.org/package/binaries/home:rinigus:qt515:packaging/qtwayland?repository=sailfish_latest_aarch64 | 18:55 |
rinigus | coming back to OBS, what is different in its workers from our SDK? in my case, they seem to behave better than sb2 on PC | 18:55 |
rinigus | lbt Keto mal : ^ (and log above) | 18:56 |
attah | Wooooo! It works! | 18:56 |
piggz | attah: screenshot or it didnt happen | 18:58 |
piggz | attah: can you provide details of improvements to sample | 18:58 |
piggz | attah: feel free to develop using charts and 3d stuff as a fancy example of new capabilities :) | 19:00 |
attah | Remind me to make an upload gui: https://meme.attah.net/qt515 | 19:02 |
attah | (fail) | 19:02 |
attah | ugh... finally fixed | 19:22 |
attah | i was just planning on making a markdown viewer | 19:23 |
mal | rinigus: in which kind of situation? | 19:32 |
rinigus | mal: I'll submit but reports regarding issues that I encountered. Then it will be easier to reply to your question specifically. | 20:23 |
mal | ok | 20:27 |
rinigus | mal: I filed two issues with https://forum.sailfishos.org/t/sdk-fails-to-run-perl-while-compiling-on-aarch64/15139 more critical for me now. but as it is late, would be better to discuss it tomorrow | 21:18 |
mal | rinigus: ok, need to test that somehow | 22:55 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!