| piggz[m] | ViGe: ping | 16:55 |
|---|---|---|
| rinigus | mal and piggz: I think qtwayland compilation fails on SFOS 4.6 since `pkg-config --cflags egl` is missing -DEGL_NO_X11. According to logs at https://build.sailfishos.org/build/sailfishos:chum:testing/4.5.0.24_i486/i586/qtbase/_log , that define is present in 4.5.x.y | 18:20 |
| rinigus | I think that adding -DQT_EGL_NO_X11 to qt config could fix it as well. just don't know where to add it to make it stick and be defined throughout all qt projects | 18:22 |
| mal | rinigus: what provides that egl, mesa? | 18:57 |
| piggz[m] | takes us back to this commit https://gitlab.freedesktop.org/mesa/mesa/-/commit/6202a13b71e18dc31ba7e2f4ea915b67eacc1ddb .... but adds the question, what defines USE_X11? | 18:58 |
| mal | yeah | 18:59 |
| rinigus | mal: that I didn't check. Sfos repos :) | 19:01 |
| mal | https://gitlab.freedesktop.org/mesa/mesa/-/commit/c71006726e20d7b6aa945947f4beb738566e05f6 | 19:03 |
| mal | still odd why building qt packages works fine in internal obs | 19:05 |
| rinigus | If you check header files that we have on sfos, then they still use egl no x11. Haven't checked these commits | 19:06 |
| rinigus | As I'm away from PC | 19:06 |
| mal | hmm | 19:06 |
| mal | 4.6 has mesa 23.1.9 | 19:07 |
| mal | and that commit piggz linked was in earlier version | 19:08 |
| mal | hmm | 19:09 |
| mal | need to look a bit more | 19:11 |
| mal | rinigus: that might be a qt bug https://invent.kde.org/qt/qt/qtwayland/-/commit/2dc725c57bb12a99f141b3852f6db516ced1661b#39865ebda7d6d165ac17eccf58aa9ba7486c9f22 | 19:21 |
| mal | so a fix would be to patch src/hardwareintegration/client/wayland-egl/wayland-egl.pri in qtwayland to define QT_EGL_NO_X11 | 19:25 |
| mal | piggz[m]: do you want to do that? | 19:26 |
| mal | as an example many places in qtbase do this https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/src/plugins/platforms/eglfs/eglfs-plugin.pro#L8 | 19:30 |
| rinigus | if piggz will not do it tonight, I can look into it tomorrow. saw those platforms in qtbase earlier today, probably is easy to add/fix that to qtwayland too. | 20:17 |
| piggz[m] | Me is walking atm ;) | 20:22 |
| piggz[m] | ah, here it is https://invent.kde.org/qt/qt/qtbase/-/blob/dev/src/gui/opengl/platform/egl/qt_egl_p.h?ref_type=heads#L36 | 21:49 |
| mal | piggz[m]: yes, that is why the patch I suggested works, it sets QT_EGL_NO_X11 which prevents that from happening | 21:58 |
| piggz[m] | yeah | 21:58 |
| piggz[m] | mal: this is it in the correct branch https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/src/platformsupport/eglconvenience/qt_egl_p.h?ref_type=heads#L67 | 22:08 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!